Repository navigation
Convert core-icons to a Kotlin Multiplatform module - #3364
Closed
StylianosGakis wants to merge 2 commits into
Closed
StylianosGakis wants to merge 2 commits into
StylianosGakis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI description
Turns
core-iconsfrom an Android library into a Kotlin Multiplatform module (JVM and Android targets) with all of its code incommonMain. Nothing changes on Android. It is the first module conversion towards running the whole app on a second platform (desktop), and it unblocks convertingfeature-profilelater.The first commit is 84 pure renames, the second is the build file, so review the second.
One thing you would not guess: the material icons dependency moves to the JetBrains coordinate pinned at 1.7.3 under its own catalog version, because JetBrains stopped publishing that artifact after 1.7.3. On Android it still resolves to the same
androidxicons 1.7.8 as before. Its iOS klibs exist but are untested against Compose 1.12, which only matters if this module ever gets iOS targets.